openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
185 stars 373 forks source link

OCPBUGS-33896: `upgrade status`: polish alert insights #1787

Closed petr-muller closed 1 month ago

petr-muller commented 1 month ago
openshift-ci-robot commented 1 month ago

@petr-muller: This pull request references Jira Issue OCPBUGS-33896, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @evakhoni

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc/pull/1787): >- skip alerts without required labels >- add context on why we show the insight (started firing during update or is known to affect updates) >- skip alerts with info level >- explicitly mention the alert does not have a runbook > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
petr-muller commented 1 month ago

/retest

petr-muller commented 1 month ago

/uncc @deads2k @mfojtik /cc @wking @Davoska

petr-muller commented 1 month ago

/test e2e-aws-ovn-serial

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/cli/admin/upgrade/OWNERS](https://github.com/openshift/oc/blob/master/pkg/cli/admin/upgrade/OWNERS)~~ [petr-muller,wking] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 672cf68abc0666caaaaeb564ab1527be2ad0fed5 and 2 for PR HEAD 751516199804821cf4006dc4963e04616e2b12ce in total

openshift-ci[bot] commented 1 month ago

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@petr-muller: Jira Issue OCPBUGS-33896: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33896 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc/pull/1787): >- skip alerts without required labels >- add context on why we show the insight (started firing during update or is known to affect updates) >- skip alerts with info level >- explicitly mention the alert does not have a runbook > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.17.0-202406010114.p0.g0bea059.assembly.stream.el9 for distgit openshift-enterprise-cli. All builds following this will include this PR.