search

openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
196 stars 377 forks source link

OCPBUGS-31848: don't manually delete must-gather's cluster role binding #1790

Closed flavianmissi closed 3 months ago

flavianmissi commented 4 months ago

instead, set the cluster role binding owner reference to the temporary must-gather namespace. when the namespace is deleted, kubernetes handles the deletion of the cluster role binding for us.

in cases where must-gather runs ends in failure, this change ensures that once users manually delete the namespace, the cluster role binding is also deleted.

openshift-ci-robot commented 4 months ago

@flavianmissi: This pull request references Jira Issue OCPBUGS-31848, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc/pull/1790): >instead, set the cluster role binding owner reference to the temporary >must-gather namespace. when the namespace is deleted, kubernetes handles >the deletion of the cluster role binding for us. > >in cases where must-gather runs ends in failure, this change ensures >that once users manually delete the namespace, the cluster role binding >is also deleted. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
flavianmissi commented 4 months ago

we want this to be pre-merge tested. holding until qe-approved. /hold

ardaguclu commented 4 months ago

Thanks for the patch. Before pre-merge test, I'm planning to complete review on Monday. Feel free to ping me, if I forget.

flavianmissi commented 4 months ago

test failure looks unrelated. /test e2e-agnostic-ovn-cmd

ardaguclu commented 4 months ago

Thanks /lgtm

flavianmissi commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@flavianmissi: This pull request references Jira Issue OCPBUGS-31848, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc/pull/1790#issuecomment-2142239553): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zhouying7780 commented 3 months ago

/label qe-approved

openshift-ci-robot commented 3 months ago

@flavianmissi: This pull request references Jira Issue OCPBUGS-31848, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc/pull/1790): >instead, set the cluster role binding owner reference to the temporary >must-gather namespace. when the namespace is deleted, kubernetes handles >the deletion of the cluster role binding for us. > >in cases where must-gather runs ends in failure, this change ensures >that once users manually delete the namespace, the cluster role binding >is also deleted. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 3 months ago

Thank you /lgtm /retest /hold until e2e-metal-ipi-ovn-ipv6 is green as it is only optional job

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc/blob/master/OWNERS)~~ [ardaguclu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ardaguclu commented 3 months ago

/retest

ingvagabund commented 3 months ago

e2e-metal-ipi-ovn-ipv6 is green /hold cancel

openshift-ci[bot] commented 3 months ago

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 months ago

@flavianmissi: Jira Issue OCPBUGS-31848: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31848 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc/pull/1790): >instead, set the cluster role binding owner reference to the temporary >must-gather namespace. when the namespace is deleted, kubernetes handles >the deletion of the cluster role binding for us. > >in cases where must-gather runs ends in failure, this change ensures >that once users manually delete the namespace, the cluster role binding >is also deleted. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.17.0-202406111641.p0.g7b485f7.assembly.stream.el9 for distgit openshift-enterprise-cli. All builds following this will include this PR.