openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
196 stars 377 forks source link

NO-JIRA: pkg/helpers: remove legacy pkg #1791

Closed flavianmissi closed 4 months ago

flavianmissi commented 4 months ago

we haven't supported "ungroupified" APIs for a couple of years. this cleans up the legacy package, effectively completely dropping support for them.

-- this is a follow up of https://github.com/openshift/oc/pull/1775.

openshift-ci-robot commented 4 months ago

@flavianmissi: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/oc/pull/1791): >we haven't supported "ungroupified" APIs for a couple of years. this cleans up the legacy package, effectively completely dropping support for them. > >-- >this is a follow up of https://github.com/openshift/oc/pull/1775. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
flavianmissi commented 4 months ago

/assign @ardaguclu

ardaguclu commented 4 months ago

This looks good to me. But before moving forward, it is better to wait the new nightly including the previous PR and check that everything is ok. After that, we can merge this.

ardaguclu commented 4 months ago

Thank you /lgtm /retest

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc/blob/master/OWNERS)~~ [ardaguclu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.17.0-202406040742.p0.gb9859d5.assembly.stream.el9 for distgit openshift-enterprise-cli. All builds following this will include this PR.