Closed rhmdnd closed 1 month ago
/retitle NO-JIRA: Update comment about using OpenFileSequential /lgtm
@rhmdnd: This pull request explicitly references no jira issue.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ardaguclu, rhmdnd
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 0bea0594b2cdb44de33be3a96f8ac2cf68e10ee2 and 2 for PR HEAD 933641913ab48b97331c78ca6d6fff9d420cb68c in total
@rhmdnd: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
This PR has been included in build ose-tools-container-v4.17.0-202406031815.p0.g143d405.assembly.stream.el9 for distgit ose-tools. All builds following this will include this PR.
A previous commit refactored OpenFileSequential since it was deprecated, and replaced it with OpenFile.
https://github.com/openshift/oc/commit/7a8c458fbbf06a1c8411e4199d61e6d43bf67334
This commit just updates the comment to be accurate, since I stumbled on it walking through the code.