openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
185 stars 373 forks source link

NO-JIRA: Update comment about using OpenFileSequential #1793

Closed rhmdnd closed 1 month ago

rhmdnd commented 1 month ago

A previous commit refactored OpenFileSequential since it was deprecated, and replaced it with OpenFile.

https://github.com/openshift/oc/commit/7a8c458fbbf06a1c8411e4199d61e6d43bf67334

This commit just updates the comment to be accurate, since I stumbled on it walking through the code.

ardaguclu commented 1 month ago

/retitle NO-JIRA: Update comment about using OpenFileSequential /lgtm

openshift-ci-robot commented 1 month ago

@rhmdnd: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/oc/pull/1793): >A previous commit refactored OpenFileSequential since it was deprecated, and replaced it with OpenFile. > > https://github.com/openshift/oc/commit/7a8c458fbbf06a1c8411e4199d61e6d43bf67334 > >This commit just updates the comment to be accurate, since I stumbled on it walking through the code. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc/blob/master/OWNERS)~~ [ardaguclu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 0bea0594b2cdb44de33be3a96f8ac2cf68e10ee2 and 2 for PR HEAD 933641913ab48b97331c78ca6d6fff9d420cb68c in total

openshift-ci[bot] commented 1 month ago

@rhmdnd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-tools-container-v4.17.0-202406031815.p0.g143d405.assembly.stream.el9 for distgit ose-tools. All builds following this will include this PR.