search

openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
185 stars 373 forks source link

[release-4.16] OCPBUGS-33917: add alert data to upgrade health in oc adm upgrade status #1794

Closed petr-muller closed 1 month ago

petr-muller commented 1 month ago

Replaces automated #1771 because multiple PRs were needed for OCPBUGS-33896.

Backports #1771 #1782 and #1787 to release 4.16:

openshift-ci-robot commented 1 month ago

@petr-muller: This pull request references Jira Issue OCPBUGS-33917, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-33896](https://issues.redhat.com//browse/OCPBUGS-33896) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-33896](https://issues.redhat.com//browse/OCPBUGS-33896) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @evakhoni

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc/pull/1794): >Backports #1771 #1782 and #1787 to release 4.16: > >- **add alerts to update health in oc adm upgrade status** >- **add mock tests for alerts in oc adm upgrade status** >- **OCPBUGS-33896: `status/inspect-alerts`: handle non-200 by Thanos** >- **inspectalerts: use client-go wrappers for thanos call debugging** >- **inspectalerts: refactor `getWithBearer` to try all urls in route** >- **`upgrade status`: polish alert insights** > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@petr-muller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 3955f41d7d95fcfb40aefe27cea1383cd39f01fe link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
petr-muller commented 1 month ago

/cc @PratikMahajan @wking @jan--f /uncc @deads2k

evakhoni commented 1 month ago

pre-merge verified /label qe-approved

petr-muller commented 1 month ago

@evakhoni can you slap the cherry-pick-approved here too?

evakhoni commented 1 month ago

np. /label cherry-pick-approved

soltysh commented 1 month ago

/label backport-risk-assessed

simonpasquier commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, simonpasquier, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/cli/admin/inspectalerts/OWNERS](https://github.com/openshift/oc/blob/release-4.16/pkg/cli/admin/inspectalerts/OWNERS)~~ [simonpasquier] - ~~[pkg/cli/admin/upgrade/OWNERS](https://github.com/openshift/oc/blob/release-4.16/pkg/cli/admin/upgrade/OWNERS)~~ [petr-muller,wking] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, simonpasquier, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/cli/admin/inspectalerts/OWNERS](https://github.com/openshift/oc/blob/release-4.16/pkg/cli/admin/inspectalerts/OWNERS)~~ [simonpasquier] - ~~[pkg/cli/admin/upgrade/OWNERS](https://github.com/openshift/oc/blob/release-4.16/pkg/cli/admin/upgrade/OWNERS)~~ [petr-muller,wking] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@petr-muller: Jira Issue OCPBUGS-33917: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33917 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc/pull/1794): >Replaces automated #1771 because multiple PRs were needed for OCPBUGS-33896. > >Backports #1771 #1782 and #1787 to release 4.16: > >- **add alerts to update health in oc adm upgrade status** >- **add mock tests for alerts in oc adm upgrade status** >- **OCPBUGS-33896: `status/inspect-alerts`: handle non-200 by Thanos** >- **inspectalerts: use client-go wrappers for thanos call debugging** >- **inspectalerts: refactor `getWithBearer` to try all urls in route** >- **`upgrade status`: polish alert insights** > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-tools-container-v4.16.0-202406042036.p0.gd9c3227.assembly.stream.el9 for distgit ose-tools. All builds following this will include this PR.