search

openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
196 stars 377 forks source link

[release-4.14] OCPBUGS-35475: Remove some of newapp unit tests relying on external deprecated images #1802

Closed openshift-cherrypick-robot closed 2 months ago

openshift-cherrypick-robot commented 3 months ago

This is an automated cherry-pick of #1726

/assign ardaguclu

openshift-ci-robot commented 3 months ago

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-31726 with correct target version. Will retitle the PR to link to the clone. /retitle [release-4.14] OCPBUGS-35475: Remove some of newapp unit tests relying on external deprecated images

In response to [this](https://github.com/openshift/oc/pull/1802): >This is an automated cherry-pick of #1726 > >/assign ardaguclu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35475, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-31726](https://issues.redhat.com//browse/OCPBUGS-31726) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-31726](https://issues.redhat.com//browse/OCPBUGS-31726) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc/pull/1802): >This is an automated cherry-pick of #1726 > >/assign ardaguclu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/helpers/newapp/OWNERS](https://github.com/openshift/oc/blob/release-4.14/pkg/helpers/newapp/OWNERS)~~ [ardaguclu,soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ardaguclu commented 3 months ago

e2e-agnostic-ovn-cmd will be fixed by https://github.com/openshift/origin/pull/28881

kasturinarra commented 3 months ago

/label cherry-pick-approved

ardaguclu commented 3 months ago

/retest-required

openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD aa6e2f22f0c7e46757d976b6eb003786196ff907 and 2 for PR HEAD 4a8e4d79fdcc9340b3ca6c497214cd5d7cf73279 in total

ardaguclu commented 3 months ago

/retest

ardaguclu commented 3 months ago

e2e-aws-ovn-builds is permafailing and it will be fixed by https://github.com/openshift/origin/pull/28840

ardaguclu commented 3 months ago

This is https://github.com/openshift/origin/pull/28904 for 4.16. We'll need this in 4.14.

ardaguclu commented 2 months ago

This is for 4.15 https://github.com/openshift/origin/pull/28927

ardaguclu commented 2 months ago

This https://github.com/openshift/origin/pull/28952 is needed to pass e2e-aws-ovn-builds.

ardaguclu commented 2 months ago

/retest

ardaguclu commented 2 months ago

/retest

ardaguclu commented 2 months ago

/retest

apoorvajagtap commented 2 months ago

@ardaguclu there are few more references to ruby-2.7 images in the bindata.go which I missed updating. I believe this is leading to the perm-failures right now, it didn't lead to failures till 4.15, because they reference ruby-3.0 which exists at present. Sending out another PR to fix these.

openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35475 is in an unrecognized state (Closed) and will not be moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc/pull/1802): >This is an automated cherry-pick of #1726 > >/assign ardaguclu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-cli This PR has been included in build openshift-enterprise-cli-container-v4.14.0-202407260844.p0.g44b3ac2.assembly.stream.el8. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-deployer This PR has been included in build openshift-enterprise-deployer-container-v4.14.0-202407260844.p0.g44b3ac2.assembly.stream.el8. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-tools This PR has been included in build ose-tools-container-v4.14.0-202407260844.p0.g44b3ac2.assembly.stream.el8. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cli-artifacts This PR has been included in build ose-cli-artifacts-container-v4.14.0-202407260844.p0.g44b3ac2.assembly.stream.el8. All builds following this will include this PR.