openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
185 stars 373 forks source link

Revert "OCPBUGS-32108: stop loading legacy schemes on global scheme " #1805

Open dgoodwin opened 2 weeks ago

dgoodwin commented 2 weeks ago

Reverts openshift/oc#1775

This will not be merged, we're trying to find a PR that fixed something which is still happening in 4.16. This PR is in the list of 4 when the problem dissappeared in 4.17.

openshift-ci-robot commented 2 weeks ago

@dgoodwin: This pull request references Jira Issue OCPBUGS-32108, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc/pull/1805): >Reverts openshift/oc#1775 > >This will not be merged, we're trying to find a PR that fixed something which is still happening in 4.16. This PR is in the list of 4 when the problem dissappeared in 4.17. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dgoodwin commented 2 weeks ago

/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn /payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn /payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn

/hold

openshift-ci[bot] commented 2 weeks ago

@dgoodwin: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8d29bcf0-3250-11ef-984e-78501d802096-0

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgoodwin Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/oc/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rphillips commented 2 weeks ago

Maybe try this once more... Looks like a CI issue.

/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn /payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn /payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn

openshift-ci[bot] commented 2 weeks ago

@rphillips: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19f8aa20-3264-11ef-9ac3-35a367096689-0