search

openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
196 stars 377 forks source link

WRKLDS-1310: pkg/cli/admin/mustgather: GA since and since-time flags #1811

Closed flavianmissi closed 3 months ago

flavianmissi commented 3 months ago

/assign @ardaguclu

openshift-ci-robot commented 3 months ago

@flavianmissi: This pull request references WRKLDS-1310 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/oc/pull/1811): >/assign @ardaguclu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 3 months ago

/lgtm /hold cancel hold whenever you'd like to merge

flavianmissi commented 3 months ago

this is safe to merge as is. /hold cancel

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc/blob/master/OWNERS)~~ [ardaguclu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD 4b158b272fb3eb0d78e4cf87dd909af2e3f823f3 and 2 for PR HEAD 17a3fe02c0f8d41c77f3588be2fe0ea51f7b8bd9 in total

ardaguclu commented 3 months ago

/retest

flavianmissi commented 3 months ago

looks like deprovisioning failed on e2e-aws-ovn-serial:

 INFO[2024-07-03T08:35:54Z] Running step e2e-aws-ovn-serial-ipi-deprovision-deprovision. 
{"component":"entrypoint","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:169","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 4h0m0s timeout","severity":"error","time":"2024-07-03T08:40:07Z"}

/retest

openshift-ci[bot] commented 3 months ago

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.17.0-202407031527.p0.g5e45e28.assembly.stream.el9 for distgit openshift-enterprise-cli. All builds following this will include this PR.