openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
185 stars 373 forks source link

OCPBUGS-36328: Set required-scc annotation to privileged for node debug pods #1816

Closed kramaranya closed 14 hours ago

kramaranya commented 3 days ago

OCPBUGS-36328

Manual cherry-pick of #1763

openshift-ci-robot commented 3 days ago

@kramaranya: This pull request references Jira Issue OCPBUGS-36328, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-35006](https://issues.redhat.com//browse/OCPBUGS-35006) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-35006](https://issues.redhat.com//browse/OCPBUGS-35006) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc/pull/1816): >[OCPBUGS-36328](https://issues.redhat.com/browse/OCPBUGS-36328) > >Manual cherry-pick of #1763 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 3 days ago

/lgtm

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, kramaranya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc/blob/release-4.16/OWNERS)~~ [ardaguclu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kramaranya commented 2 days ago

/retest-required

openshift-ci[bot] commented 2 days ago

@kramaranya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ardaguclu commented 17 hours ago

@kramaranya the remaining tags can be done by @ingvagabund and @kasturinarra

ingvagabund commented 14 hours ago

/label backport-risk-assessed

xingxingxia commented 14 hours ago

/label cherry-pick-approved

openshift-ci-robot commented 14 hours ago

@kramaranya: Jira Issue OCPBUGS-36328: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36328 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc/pull/1816): >[OCPBUGS-36328](https://issues.redhat.com/browse/OCPBUGS-36328) > >Manual cherry-pick of #1763 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 hours ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-tools-container-v4.16.0-202407081937.p0.g0127eb4.assembly.stream.el9 for distgit ose-tools. All builds following this will include this PR.