openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
196 stars 377 forks source link

WRKLDS-1429: Adds a guardrail for node-image commands which is supported only for Openshift version 4.17+ #1837

Closed pawanpinjarkar closed 1 month ago

pawanpinjarkar commented 2 months ago

Adds a guardrail for node-image commands which is supported only for Openshift version 4.17+

openshift-ci-robot commented 2 months ago

@pawanpinjarkar: This pull request references WRKLDS-1429 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/oc/pull/1837): >Adds a guardrail for node-image commands which is supported only for Openshift version 4.17+ Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
pawanpinjarkar commented 2 months ago

/test unit

pawanpinjarkar commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawanpinjarkar, rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/cli/admin/nodeimage/OWNERS](https://github.com/openshift/oc/blob/master/pkg/cli/admin/nodeimage/OWNERS)~~ [pawanpinjarkar,rwsu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 4e7fcfe6aee8558c0fe20f79509a83a7b6ea75a7 and 2 for PR HEAD 75954502ff018ad609861bf96da150a2c1565e36 in total

openshift-ci[bot] commented 1 month ago

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-cli This PR has been included in build openshift-enterprise-cli-container-v4.17.0-202408070442.p0.gc2b6a62.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-tools This PR has been included in build ose-tools-container-v4.17.0-202408070442.p0.gc2b6a62.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-deployer This PR has been included in build openshift-enterprise-deployer-container-v4.17.0-202408070442.p0.gc2b6a62.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cli-artifacts This PR has been included in build ose-cli-artifacts-container-v4.17.0-202408070442.p0.gc2b6a62.assembly.stream.el9. All builds following this will include this PR.