search

openshift / oc

The OpenShift Command Line, part of OKD
https://www.openshift.org
Apache License 2.0
196 stars 377 forks source link

OCPBUGS-37853: Revert "OCPBUGS-35994: pkg/cli/admin/upgrade/rollback: Drop this command" #1839

Closed openshift-cherrypick-robot closed 2 months ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #1827

/assign wking

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-37345 with correct target version. Will retitle the PR to link to the clone. /retitle [release-4.16] OCPBUGS-37853: Revert "OCPBUGS-35994: pkg/cli/admin/upgrade/rollback: Drop this command"

In response to [this](https://github.com/openshift/oc/pull/1839): >This is an automated cherry-pick of #1827 > >/assign wking Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-37853, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc/pull/1839): >This is an automated cherry-pick of #1827 > >/assign wking Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
wking commented 2 months ago

Git(Hub) metadata is enough to show that this pull targets 4.16, and the message is already chatty enough without that:

/retitle OCPBUGS-37853: Revert "OCPBUGS-35994: pkg/cli/admin/upgrade/rollback: Drop this command"

wking commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@wking: This pull request references Jira Issue OCPBUGS-37853, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-37345](https://issues.redhat.com//browse/OCPBUGS-37345) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-37345](https://issues.redhat.com//browse/OCPBUGS-37345) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @jiajliu

In response to [this](https://github.com/openshift/oc/pull/1839#issuecomment-2264379382): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/cli/admin/upgrade/OWNERS](https://github.com/openshift/oc/blob/release-4.16/pkg/cli/admin/upgrade/OWNERS)~~ [wking] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shellyyang1989 commented 2 months ago

Hi @kasturinarra @zhouying7780 would you mind adding cherry-pick-approved?

shellyyang1989 commented 2 months ago

/test e2e-aws-ovn-upgrade

ingvagabund commented 2 months ago

/label backport-risk-assessed

openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kasturinarra commented 2 months ago

/label cherry-pick-approved

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-37853: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-37853 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc/pull/1839): >This is an automated cherry-pick of #1827 > >/assign wking Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-cli This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202408021139.p0.ge8fb3c0.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-tools This PR has been included in build ose-tools-container-v4.16.0-202408021139.p0.ge8fb3c0.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-deployer This PR has been included in build openshift-enterprise-deployer-container-v4.16.0-202408021139.p0.ge8fb3c0.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cli-artifacts This PR has been included in build ose-cli-artifacts-container-v4.16.0-202408021139.p0.ge8fb3c0.assembly.stream.el9. All builds following this will include this PR.

openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.16.0-0.nightly-2024-08-06-073514