[OSD-15271] skip osdctl version check when generating bash completion

openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts

Apache License 2.0

10 stars 63 forks source link

[OSD-15271] skip osdctl version check when generating bash completion #164

Closed T0MASD closed 1 year ago

T0MASD commented 1 year ago

Since osdctl started to check for version, ocm-container build can get stuck due to required user input for osdctl completion command as seen from:

$ ./osdctl completion bash
The current version () is different than the latest released version (v0.14.0).
It is recommended that you update to the latest released version to ensure that no known bugs or issues are hit.
Please confirm that you would like to continue with [y|n]

clcollins commented 1 year ago

/lgtm /approve

I realize we should probably strive to make sure osdctl is up to date, but there are definitely use cases for building with an older version.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, T0MASD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [clcollins] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment