search

openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

Adds the new public backplane cli #174

Closed iamkirkbater closed 1 year ago

iamkirkbater commented 1 year ago

This adds the new public backplane cli to ocm-container.

I recommend pulling this PR and then building as a tagged version of the container:

gh pr checkout 174
podman build -t ocm-container:publicbp .
ocm-container -t publicbp [cluster-id]
iamkirkbater commented 1 year ago

This doesn't have a hard dependency on the backplane changes, as it works independently without it, we would just end up duplicating config locally or setting a local env var for working with backplane outside of the container.

clcollins commented 1 year ago

This is still beta, I think? It'd be worth holding off merging this into the main branch until there's been a little more testing, but maybe we can create a dev branch here for cases like these where we want to make it easy to test, but wouldn't want to make it the default for everyone until it's been tested more?

clcollins commented 1 year ago

/hold

We're gonna hold this while backplane is tested more, but maintain the PR branch so folks can clone and use it for testing easily.

AlexVulaj commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rendhalver commented 1 year ago

Getting a cluster console is not working with this and that's a blocker. We need podman and a few other components from the old backplane for this to work properly. We need to hold off merging this until console works.

T0MASD commented 1 year ago

/unhold

openshift-merge-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iamkirkbater commented 1 year ago

Closing this as the changes were incorporated as part of #187