search

openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

Add mount for managed notifications #195

Closed rendhalver closed 1 year ago

rendhalver commented 1 year ago

I keep needing to use these for service logs so adding a mount for them seems like a good plan

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rendhalver Once this PR has been reviewed and has the lgtm label, please assign rogbas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clcollins commented 1 year ago

This is a public repo, as opposed to ops-sop ($OPS_UTILS_DIR). Why not build it into the image and skip all the mounting business?

Additionally, this is only useful with osdctl which also parses the template from URL, so does it need to be local at all?

rendhalver commented 1 year ago

This is a public repo, as opposed to ops-sop ($OPS_UTILS_DIR). Why not build it into the image and skip all the mounting business?

Additionally, this is only useful with osdctl which also parses the template from URL, so does it need to be local at all?

Very good points. Thanks for the sanity check Chris.

I think the only reason this would be used would be for sending edited copies of the ones in managed-notifications and that's probably just encouraging bad behavior. I am gonna stop myself and others from doing that and close this.