Closed T0MASD closed 10 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: T0MASD Once this PR has been reviewed and has the lgtm label, please assign iamkirkbater for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
This is awesome, and LGTM generally. Would you be opposed to the function taking an argument to add the REASON via a flag using bash's GETOPS (or something), to support just running it with a flag, or prompting if run without one?
Something like oc-elevate -r "This was my reason for elevating"
?
Oh, and one more idea - this is already named properly and would be an excellent candidate for an OC plugin - it just needs to go into /usr/local/bin
instead of the bashrc.d utils, and execute the function automatically.
oc elevate get pod -A....
+1 to having a reason passed in and not have to provide it in a text prompt afterwards.
I also think that having the reason be mandatory and explicitly fail out if there's no reason provided would be a better option here. The whole point is to provide a reason why you're escalating so you don't get a compliance ticket, otherwise --as backplane-cluster-admin
would be sufficient.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen
.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Exclude this issue from closing again by commenting /lifecycle frozen
.
/close
@openshift-bot: Closed this PR.
prompts for justification before commands as cluster admin
example when providing a justification:
example when not providing a justification due to timeout or empty string
Confirmed with security team, justification is sent to the audit log