openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

Adds the ability to provide the JIRA auth via env vars #219

Closed iamkirkbater closed 1 year ago

iamkirkbater commented 1 year ago

I already had the env vars set and don't have them available in a token file, so I added the ability to fallback to the env vars if they're already set.

These could also in theory be set to .env.source as well, but it allows for both.

clcollins commented 1 year ago

/lgtm /approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [clcollins,iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment