search

openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

don't get the hypershift binary if on arm64 #235

Closed iamkirkbater closed 9 months ago

iamkirkbater commented 10 months ago

Allows the container to build for non-x86_64 machines.

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
T0MASD commented 10 months ago

tested on arm64 machine, however I get a build error:

--> 428c0e5aa71f
[16/16] STEP 25/40: RUN ocm backplane completion bash > /etc/bash_completion.d/ocm-backplane
--> f220c88293a5
[16/16] STEP 26/40: RUN hypershift --version
qemu-x86_64-static: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory
Error: building at STEP "RUN hypershift --version": while running runtime: exit status 255

it appears binary is not overwritten

[~ {production} ]$ du -h /usr/local/bin/hypershift
127M    /usr/local/bin/hypershift

I ran the build on a system with no images

rendhalver commented 9 months ago

I believe this is contained within #245. /hold