search

openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

add advanced upgrade service (AUS) CLI #239

Closed geoberle closed 9 months ago

geoberle commented 9 months ago

the AUS CLI utility is an OCM CLI plugin to manage AUS upgrade policies on clusters and organizations in OCM

https://source.redhat.com/groups/public/sre/wiki/advanced_upgrade_service_aus

adding this to ocm-container is beneficial for AUS users, since they get the AUS plugin bundled with an up to date OCM utility. this way ocm-container can be used in CI systems where they validate their AUS policies and apply them after merge.

part of https://issues.redhat.com/browse/APPSRE-8538

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geoberle Once this PR has been reviewed and has the lgtm label, please assign alexvulaj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clcollins commented 9 months ago

Hi @geoberle, thanks for the PR!

Who is the intended audience for the AUS utility? They majority of users of ocm-container are likely SREP, who don't really have anything to do with scheduling upgrades. However, I think it's fair to add utilities others might find helpful as well. We just want to balance how much may need to be in the "core" ocm-container, and what might be added by other teams using ocm-container as a base image to customize their own.

What are your thoughts on this?

geoberle commented 9 months ago

Who is the intended audience for the AUS utility?

most RH engineering teams using AUS to declare their cluster upgrade policies but also AppSRE folks when giving support for AUS

want to balance

i understand your point

using ocm-container as a base image

i discussed this with the team and you are right, we will build our own image on top of ocm-container and i will close this PR. thanks for the suggestion