search

openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

add yum-utils and disable google repo #250

Closed T0MASD closed 4 months ago

T0MASD commented 6 months ago

add yum-utils and disable google repo after gcloud install as it is often source of timeouts when building on top of ocm-container in the future

iamkirkbater commented 6 months ago

Are these related to daily ops tasks? I think adding these tools might be a bit too far of a deviation from the spirit of ocm-container, which is mainly to provide a stable, reproducible environment for SREs to access clusters and perform operations-related tasks.

I think running terraform tasks and packer operations falls outside of that scope.

I'm putting a hold on this for further discussion though.

/hold

T0MASD commented 6 months ago

I've updated the PR to essentially disable google-cloud-sdk repo after the container build as it is often source of time outs for follow up builds

clcollins commented 4 months ago

/lgtm

With the yum-utils and google-sdk changes, minus the others. :+1:

clcollins commented 4 months ago

/retest

clcollins commented 4 months ago

/unhold

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, T0MASD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [T0MASD,clcollins] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment