openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

Adds extra build configuration to allow building multiple architectures #255

Closed iamkirkbater closed 5 months ago

iamkirkbater commented 5 months ago

Adds additional configuration to build for multiple architectures.

I tried to add the functionality while keeping the original make targets like make build work the same as they do now for those who may be using those.

I highly recommend installing GNU parallel in order to build both at the same time. It takes ~20m to build amd64 on an arm64 laptop, FWIW.

Steps to test: (change IMAGE_REPOSITORY to your quay.io repo)

iamkirkbater commented 5 months ago

/hold

Let's wait to see if the nightly builds are working first before merging this and adding a new variable to the mix.

iamkirkbater commented 5 months ago

/hold cancel

rendhalver commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, rendhalver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [iamkirkbater,rendhalver] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment