openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

adds buildx command to docker multi-platform builds #256

Closed iamkirkbater closed 3 months ago

iamkirkbater commented 4 months ago

Still need to address the 403 errors from Github, but that's a whole pile of sticks to address so let's start with just getting Docker to actually pull the correct images and see if that might start working on the nightly builds/pr checks.

Removed the caching in PR checks. We might need to refactor this because if we attempt to run multiple PR checks in quick succession this will hit the GH rate limiting. However, if we hit the rate-limiting and the build fails, it will cache that 403 response in the image layer and fail the build later.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rendhalver commented 4 months ago

/retest

rendhalver commented 4 months ago

/retest

clcollins commented 4 months ago

/hold

Dealing with other platform/arch issues ATM

openshift-merge-robot commented 4 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iamkirkbater commented 3 months ago

I'm going to close this as this will be fixed as we move to Konflux.