search

openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

Add servielogger #258

Closed rendhalver closed 3 months ago

rendhalver commented 4 months ago

Add servicelogger

rendhalver commented 4 months ago

/retest

rendhalver commented 4 months ago

/retest

rendhalver commented 4 months ago

/hold Need to split out the backplane-tools update/

clcollins commented 4 months ago

/retest

clcollins commented 4 months ago

@rendhalver the tests are unblocked for now. Do you want to rebase and finish this one up?

rendhalver commented 3 months ago

@rendhalver the tests are unblocked for now. Do you want to rebase and finish this one up?

@clcollins Done! Ready for a review.

clcollins commented 3 months ago

/unhold /lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, rendhalver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [clcollins,rendhalver] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment