openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

BACKPLANE_CONFIG_MOUNT as rw because cluster-console attempt to write a config there #264

Closed T0MASD closed 3 months ago

T0MASD commented 3 months ago

Since we now use single backplane config for all envs, it should be ok to mount the bp conf location as rw, especially since cluster-console command attempts to write a temp nginx config there...

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: T0MASD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [T0MASD] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rendhalver commented 3 months ago

/hold Chris is working on moving the cli into Golang and he has pushed the console parts into Golang as well. Let's hold off on this until we get that merged.

clcollins commented 3 months ago

Fixed by #265

iamkirkbater commented 3 months ago

/close

openshift-merge-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

@iamkirkbater: Closed this PR.

In response to [this](https://github.com/openshift/ocm-container/pull/264#issuecomment-2074824126): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.