search

openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

add persistentImages #281

Closed T0MASD closed 2 months ago

T0MASD commented 2 months ago

Add persistentImages feature which perserves local images between ocm-container sessions

T0MASD commented 2 months ago

/unhold

T0MASD commented 2 months ago

/hold for fix to left over containers

$ podman ps -aq
bd2a8b53fd5c
e8bfe9d90987
T0MASD commented 2 months ago

it's not possible to mount just /var/lib/containers/storage/overlay/ in addition verified 2 container sessions happily share the mount

T0MASD commented 2 months ago

/unhold

T0MASD commented 2 months ago

/label tide/merge-method-squash

T0MASD commented 2 months ago

@clcollins I've addressed the issue I have brought up earlier in https://github.com/openshift/backplane-cli/pull/419 this change is good to go!

clcollins commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, T0MASD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [T0MASD,clcollins] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment