openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

Make blackbox-exporter launcher a clickable link #289

Closed clcollins closed 1 month ago

clcollins commented 1 month ago

This PR makes the output of the blackbox-exporter launcher script output a clickable link in the style of the cluster-console script.

Signed-off-by: Chris Collins collins.christopher@gmail.com

clcollins commented 1 month ago

/retest

rendhalver commented 1 month ago

Nice! Thanks Chris! Copied it into my container and it's working as expected.

[~ {prod} ]$ ocm backplane login osd-v4stg-aws
[~ {prod} (osd-v4stg-aws.z9a9.p1:default)]$ ./scratch/bin/blackbox-exporter 
== Blackbox exporter is available at http://127.0.0.1:38501 ==
Handling connection for 9999

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, rendhalver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [clcollins,rendhalver] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rendhalver commented 1 month ago

/retest

rendhalver commented 1 month ago

The builds look to be failing on the gpg key for the gcloud-sdk repo. We aren't using that and we can install it from backplane-tools anyway so we will do that. Step one is in #290.

rendhalver commented 1 month ago

/retest