search

openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

Allows passing in the ocm config for short-lived ocm token support #295

Closed iamkirkbater closed 3 weeks ago

iamkirkbater commented 3 weeks ago

Adds initial support for short-lived OCM tokens. You'll need to auth before you get into the container using ocm login --use-auth-code and then after you are logged in outside of the container your auth will be passed into the container.

This should remain in draft until the next OCM CLI is released so that we can use the OCM_URL environment variable to override which endpoint to use (int, stage, prod, regional, etc), otherwise this will only work for whatever environment you're logged into OUTSIDE of the conatiner.

iamkirkbater commented 3 weeks ago

/approve cancel

rendhalver commented 3 weeks ago

I have tested this with the latest build of our container that has ocm 0.1.74. Everything worked as expected.

rendhalver commented 3 weeks ago

/lgtm /approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rendhalver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [rendhalver] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment