search

openshift / ocm-container

Containerized environment for accessing OpenShift v4 clusters, packing necessary tools/scripts
Apache License 2.0
10 stars 63 forks source link

Add 'name' parameter for OCM cluster search #301

Closed clcollins closed 1 month ago

clcollins commented 1 month ago

Some clusters use "display_name" as a longer, more descriptive field. And example of this is osd-v4stg-aws, which has:

Display Name:   SRE long lived cluster in production: osd-v4stg-aws

This causes osd-v4stg-aws (or others) to not be found when searching by the human friendly name, as identified by @rendhalver in a recent pr review.

This PR adds "name" to the OCM cluster search parameters, which is the parameter used by ocm-cli when it performs the same search.

Signed-off-by: Chris Collins collins.christopher@gmail.com

rendhalver commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, rendhalver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocm-container/blob/master/OWNERS)~~ [clcollins,rendhalver] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rendhalver commented 1 month ago

/retest