search

openshift / ocp-release-operator-sdk

Apache License 2.0
16 stars 39 forks source link

Merge upstream tag v1.25.1 #288

Closed everettraven closed 2 years ago

everettraven commented 2 years ago

Operator SDK v1.25.1

Merge executed via ./UPSTREAM-MERGE.sh v1.25.1

Note The only change that was made that will impact users is an update to the operator-sdk bundle validate logic that will now verify that no potentially deprecated APIs are found in the ClusterServiceVersion.

To test this functionality:

  1. I cloned the community-operators repo with:

    git clone https://github.com/k8s-operatorhub/community-operators.git

  2. I navigated to the couchbase-enterprise operator directory:

    cd community-operators/operators/couchbase-enterprise

  3. Ran:

    operator-sdk bundle validate 2.3.0/ --select-optional suite=operatorframework --optional-values=k8s-version=1.25

  4. Verified the output matched the expected of:

    WARN[0000] Warning: Value couchbase-operator.v2.3.0-1: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for events: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[8]"]),poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[10]"]), 
ERRO[0000] Error: Value couchbase-operator.v2.3.0-1: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for CronJob: (["ClusterServiceVersion.Spec.CustomResourceDefinitions.Owned[8].Resource[0]"]) 
WARN[0000] Warning: Value couchbase-operator.v2.3.0-1: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for events: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[8]"]),poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[10]"]), 
ERRO[0000] Error: Value couchbase-operator.v2.3.0-1: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for CronJob: (["ClusterServiceVersion.Spec.CustomResourceDefinitions.Owned[8].Resource[0]"]) 
WARN[0000] Warning: Value couchbase-operator.v2.3.0-1: unable to find the resource requests for the container: (couchbase-operator). It is recommended to ensure the resource request for CPU and Memory. Be aware that for some clusters configurations it is required to specify requests or limits for those values. Otherwise, the system or quota may reject Pod creation. More info: https://master.sdk.operatorframework.io/docs/best-practices/managing-resources/
openshift-ci[bot] commented 2 years ago

Hi @everettraven. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
michaelryanpeter commented 2 years ago

/label docs-approved

theishshah commented 2 years ago

/ok-to-test

openshift-ci[bot] commented 2 years ago

@everettraven: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jmrodri commented 2 years ago

@emmajiafan @KeenonLee The main thing added in this release is the validation of 1.25 from bundle validate. the other changes you see were a result of an expired GPG release key which we had to also address to get this release out upstream.

everettraven commented 2 years ago

I updated the PR description comment, but just in case I wanted to add another comment with this info:

Note The only change that was made that will impact users is an update to the operator-sdk bundle validate logic that will now verify that no potentially deprecated APIs are found in the ClusterServiceVersion.

To test this functionality:

  1. I cloned the community-operators repo with:

    git clone https://github.com/k8s-operatorhub/community-operators.git

  2. I navigated to the couchbase-enterprise operator directory:

    cd community-operators/operators/couchbase-enterprise

  3. Ran:

    operator-sdk bundle validate 2.3.0/ --select-optional suite=operatorframework --optional-values=k8s-version=1.25

  4. Verified the output matched the expected of:

    WARN[0000] Warning: Value couchbase-operator.v2.3.0-1: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for events: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[8]"]),poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[10]"]), 
ERRO[0000] Error: Value couchbase-operator.v2.3.0-1: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for CronJob: (["ClusterServiceVersion.Spec.CustomResourceDefinitions.Owned[8].Resource[0]"]) 
WARN[0000] Warning: Value couchbase-operator.v2.3.0-1: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for events: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[8]"]),poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[10]"]), 
ERRO[0000] Error: Value couchbase-operator.v2.3.0-1: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for CronJob: (["ClusterServiceVersion.Spec.CustomResourceDefinitions.Owned[8].Resource[0]"]) 
WARN[0000] Warning: Value couchbase-operator.v2.3.0-1: unable to find the resource requests for the container: (couchbase-operator). It is recommended to ensure the resource request for CPU and Memory. Be aware that for some clusters configurations it is required to specify requests or limits for those values. Otherwise, the system or quota may reject Pod creation. More info: https://master.sdk.operatorframework.io/docs/best-practices/managing-resources/
KeenonLee commented 2 years ago

/label qe-approved

jmrodri commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, jmrodri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocp-release-operator-sdk/blob/master/OWNERS)~~ [jmrodri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jmrodri commented 2 years ago

/cherry-pick release-4.12

openshift-cherrypick-robot commented 2 years ago

@jmrodri: new pull request created: #289

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/288#issuecomment-1314302402): >/cherry-pick release-4.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.