search

openshift / ocp-release-operator-sdk

Apache License 2.0
16 stars 38 forks source link

OCPBUGS-5429: [release-4.12] Merge upstream tag v1.25.1 #296

Closed everettraven closed 1 year ago

everettraven commented 1 year ago

This is a manual cherry-pick of #288 to release-4.12 branch.

Reason for manual cherry-pick: There seems to be an issue with the vendor files in the automated cherry-pick PR #289 . I don't have permissions to push the fix from running go mod vendor, so in an effort to expedite the process I created this branch from the cherry pick bots branch.

openshift-ci[bot] commented 1 year ago

@everettraven: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/296): >[release-4.12] Merge upstream tag v1.25.1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@everettraven: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/296): >[release-4.12] Merge upstream tag v1.25.1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
oceanc80 commented 1 year ago

/approve

oceanc80 commented 1 year ago

/label backport-risk-assessed

openshift-ci[bot] commented 1 year ago

@oceanc80: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/296#issuecomment-1372404781): >/label backport-risk-assessed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@everettraven: This pull request references Jira Issue OCPBUGS-5429, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/296): >This is a manual cherry-pick of #288 to `release-4.12` branch. > >**Reason for manual cherry-pick**: There seems to be an issue with the vendor files in the automated cherry-pick PR #289 . I don't have permissions to push the fix from running `go mod vendor`, so in an effort to expedite the process I created this branch from the cherry pick bots branch. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@everettraven: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/296): >OCPBUGS-5429: [release-4.12] Merge upstream tag v1.25.1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
everettraven commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@everettraven: This pull request references Jira Issue OCPBUGS-5429, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/296#issuecomment-1372644690): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
everettraven commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@everettraven: This pull request references Jira Issue OCPBUGS-5429, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/296#issuecomment-1372645294): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
everettraven commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@everettraven: This pull request references Jira Issue OCPBUGS-5429, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.0) matches configured target version for branch (4.12.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-5432](https://issues.redhat.com//browse/OCPBUGS-5432) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-5432](https://issues.redhat.com//browse/OCPBUGS-5432) targets the "4.13.0" version, which is one of the valid target versions: 4.13.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jfan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/296#issuecomment-1372719007): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
oceanc80 commented 1 year ago

/approve

oceanc80 commented 1 year ago

/label backport-risk-assessed

everettraven commented 1 year ago

/label cherry-pick-approved

openshift-ci[bot] commented 1 year ago

@everettraven: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/296#issuecomment-1372836489): >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
emmajiafan commented 1 year ago

@everettraven Others looks good except the file "UPSTREAM-VERSION" is still 1.25.0

everettraven commented 1 year ago

@emmajiafan I updated the UPSTREAM-VERSION file as of commit https://github.com/openshift/ocp-release-operator-sdk/pull/296/commits/0625fc5dfa18f22e1863d55483b962bb4daeb24f

openshift-ci[bot] commented 1 year ago

@everettraven: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
emmajiafan commented 1 year ago

/label qe-approved

everettraven commented 1 year ago

@emmajiafan Are you able to add the cherry-pick-approved label?

emmajiafan commented 1 year ago

/label cherry-pick-approved

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, oceanc80, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocp-release-operator-sdk/blob/release-4.12/OWNERS)~~ [varshaprasad96] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

@everettraven: Jira Issue OCPBUGS-5429 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/296): >This is a manual cherry-pick of #288 to `release-4.12` branch. > >**Reason for manual cherry-pick**: There seems to be an issue with the vendor files in the automated cherry-pick PR #289 . I don't have permissions to push the fix from running `go mod vendor`, so in an effort to expedite the process I created this branch from the cherry pick bots branch. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.