Closed oceanc80 closed 1 year ago
I think a lot (if not all) of the changes to things outside the
release/ansible
folder will end being synced downstream with the next upstream SDK release (v1.31.0). To prevent sync issues due to divergence I think we should hold this PR until v1.31.0 is downstreamed and then rebase this PR against themaster
branch./hold
Yea I just noticed that this is changing 410 files. That seems like a lot :)_
/hold cancel
/retest
/retest-required
Remaining retests: 0 against base HEAD 74e49e81bfef171456e39a075ca24bd4dae2bc8e and 2 for PR HEAD 0ced4a9c1e31c7a78e7a67223a7a7d2ebb1a0674 in total
I'm a bit confused about the 391 changed files. Is this typical, or is a rebase required here?
I'm a bit confused about the 391 changed files. Is this typical, or is a rebase required here?
@leifmadsen I think this is typical since we updated some dependencies that are required to be vendored in. I don't think the vendoring will be necessary once the cachito stuff is in but if I understand correctly in the meantime we need to still vendor the new versions in.
/retest-required
/retest-required
/test unit
@oceanc80: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: everettraven, grokspawn, oceanc80
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description of the change:
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs