openshift / ocp-release-operator-sdk

Apache License 2.0
16 stars 38 forks source link

Update python and ansible, remove preview image #333

Closed oceanc80 closed 1 year ago

oceanc80 commented 1 year ago

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

leifmadsen commented 1 year ago

I think a lot (if not all) of the changes to things outside the release/ansible folder will end being synced downstream with the next upstream SDK release (v1.31.0). To prevent sync issues due to divergence I think we should hold this PR until v1.31.0 is downstreamed and then rebase this PR against the master branch.

/hold

Yea I just noticed that this is changing 410 files. That seems like a lot :)_

everettraven commented 1 year ago

/hold cancel

everettraven commented 1 year ago

/retest

openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD 74e49e81bfef171456e39a075ca24bd4dae2bc8e and 2 for PR HEAD 0ced4a9c1e31c7a78e7a67223a7a7d2ebb1a0674 in total

leifmadsen commented 1 year ago

I'm a bit confused about the 391 changed files. Is this typical, or is a rebase required here?

everettraven commented 1 year ago

I'm a bit confused about the 391 changed files. Is this typical, or is a rebase required here?

@leifmadsen I think this is typical since we updated some dependencies that are required to be vendored in. I don't think the vendoring will be necessary once the cachito stuff is in but if I understand correctly in the meantime we need to still vendor the new versions in.

oceanc80 commented 1 year ago

/retest-required

oceanc80 commented 1 year ago

/retest-required

joelanford commented 1 year ago

/test unit

openshift-ci[bot] commented 1 year ago

@oceanc80: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
grokspawn commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn, oceanc80

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocp-release-operator-sdk/blob/master/OWNERS)~~ [everettraven,grokspawn,oceanc80] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment