openshift / ocp-release-operator-sdk

Apache License 2.0
16 stars 38 forks source link

OCPBUGS-: update openshift plugin for CVE-2023-44487 & CVE-2023-39325 #340

Closed everettraven closed 11 months ago

everettraven commented 11 months ago

Description of the change:

Motivation for the change:

[!Warning] This does not update or guarantee that the operator-sdk binary itself is being built with a fixed version of Go and golang.org/x/net v0.17.0 and will still need to be done in a separate pull request to fully address these CVEs

Additional Context I've manually verified that this works on this branch by building the operator-sdk binary with:

$ make -f ci/prow.Makefile patch build

and creating a minimal go/v3 project (in a separate directory):

$ go mod init example.com

$ /Users/bpalmer/github/ocp-release-operator-sdk/build/operator-sdk init --domain example.org

Verification of changes taking place:

$ cat Dockerfile
# Build the manager binary
FROM golang:1.20 as builder
...

$ cat go.mod | grep -i go
go 1.20
...

$ cat go.mod | grep -i golang.org/x/net
    golang.org/x/net v0.17.0 // indirect

$ cat go.sum | grep -i golang.org/x/net
...
golang.org/x/net v0.17.0 h1:pVaXccu2ozPjCXewfr1S7xza/zcXTity9cCdXQYSjIM=
golang.org/x/net v0.17.0/go.mod h1:NxSsAGuq816PNPmqtQdLE42eU2Fs7NoRIZrHJAlaCOE=
openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocp-release-operator-sdk/blob/master/OWNERS)~~ [everettraven] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
everettraven commented 11 months ago

/hold

openshift-ci[bot] commented 11 months ago

@everettraven: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit d329b84aa3fbf990207b53fedd6c2d18da42eec1 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).