search

openshift / ocp-release-operator-sdk

Apache License 2.0
16 stars 38 forks source link

Fix Ansible rework with Cachito #350

Closed vfreex closed 11 months ago

vfreex commented 11 months ago
  1. Fix Python package path.
  2. Use a newer version of setuptools.
  3. WORKDIR is removed because we are going to delete $REMOTE_SOURCES_DIR.
  4. Use websocket-client==1.3.1 since it is the latest version supporting python 3.6.
openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vfreex Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/ocp-release-operator-sdk/blob/ansible-rework/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-merge-robot commented 11 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
leifmadsen commented 11 months ago

I'll look at pulling some of these changes into the existing working branches. This is out of date of where I'm at now.

leifmadsen commented 11 months ago

These changes should be integrated into PR#353 now.

vfreex commented 11 months ago

@leifmadsen I am going to close this. Thanks