search

openshift / ocp-release-operator-sdk

Apache License 2.0
16 stars 38 forks source link

OCPBUGS-36458: Rename Dockerfile #386

Closed ashwindasr closed 2 months ago

ashwindasr commented 3 months ago

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: https://github.com/openshift/release/pull/53937

Please follow up with other changes in this/other repos if necessary. ART has setup the necessary fallbacks, but only for 4.17, if backporting this PR, please give us a heads up.

openshift-ci-robot commented 3 months ago

@ashwindasr: This pull request references Jira Issue OCPBUGS-36458, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jfan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/386): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative since contents are actually rhel9. > >CI: https://github.com/openshift/release/pull/53937 > >Please follow up with other changes in this/other repos if necessary. ART has setup the necessary [fallbacks](https://github.com/openshift-eng/ocp-build-data/pull/5039), but only for 4.17, if backporting this PR, please give us a heads up. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Focp-release-operator-sdk). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ashwindasr commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocp-release-operator-sdk/blob/master/OWNERS)~~ [everettraven] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oceanc80 commented 2 months ago

/label px-approved

openshift-ci-robot commented 2 months ago

@ashwindasr: This pull request references Jira Issue OCPBUGS-36458, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jfan@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/386): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative since contents are actually rhel9. > >CI: https://github.com/openshift/release/pull/53937 > >Please follow up with other changes in this/other repos if necessary. ART has setup the necessary [fallbacks](https://github.com/openshift-eng/ocp-build-data/pull/5039), but only for 4.17, if backporting this PR, please give us a heads up. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Focp-release-operator-sdk). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@ashwindasr: Jira Issue OCPBUGS-36458: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36458 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/386): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative since contents are actually rhel9. > >CI: https://github.com/openshift/release/pull/53937 > >Please follow up with other changes in this/other repos if necessary. ART has setup the necessary [fallbacks](https://github.com/openshift-eng/ocp-build-data/pull/5039), but only for 4.17, if backporting this PR, please give us a heads up. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Focp-release-operator-sdk). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-helm-operator-container-v4.17.0-202407090841.p0.g567c188.assembly.stream.el9 for distgit openshift-enterprise-helm-operator. All builds following this will include this PR.