search

openshift / ocp-release-operator-sdk

Apache License 2.0
16 stars 39 forks source link

OCPBUGS-42425: Update base image of scaffolded Dockerfile for helm-operator to use rhel9 repository #397

Closed arkadeepsen closed 1 month ago

arkadeepsen commented 1 month ago

Description of the change: Update base image of scaffolded Dockerfile for helm-operator to use rhel9 repository

Motivation for the change: The helm-operator image is using rhel9 base image from 4.16 onwards and discontinued publishing rhel8 based image. The repository also has changed from registry.redhat.io/openshift4/ose-helm-operator to registry.redhat.io/openshift4/ose-helm-rhel9-operator. This PR fixes the scaffolded Dockerfile for helm-operator to use the correct image.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

openshift-ci-robot commented 1 month ago

@arkadeepsen: This pull request references Jira Issue OCPBUGS-42425, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @KeenonLee

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/397): > > >**Description of the change:** >Update base image of scaffolded Dockerfile for helm-operator to use rhel9 repository > >**Motivation for the change:** >The helm-operator image is using rhel9 base image from 4.16 onwards and discontinued publishing rhel8 based image. The repository also has changed from `registry.redhat.io/openshift4/ose-helm-operator` to `registry.redhat.io/openshift4/ose-helm-rhel9-operator`. This PR fixes the scaffolded Dockerfile for helm-operator to use the correct image. > >**Checklist** > >If the pull request includes user-facing changes, extra documentation is required: >- [ ] Add a new changelog fragment in `changelog/fragments` (see [`changelog/fragments/00-template.yaml`](https://github.com/operator-framework/operator-sdk/tree/master/changelog/fragments/00-template.yaml)) >- [ ] Add or update relevant sections of the docs website in [`website/content/en/docs`](https://github.com/operator-framework/operator-sdk/tree/master/website/content/en/docs) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Focp-release-operator-sdk). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkadeepsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ocp-release-operator-sdk/blob/master/OWNERS)~~ [arkadeepsen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
arkadeepsen commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@arkadeepsen: This pull request references Jira Issue OCPBUGS-42425, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @KeenonLee

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/397): > > >**Description of the change:** >Update base image of scaffolded Dockerfile for helm-operator to use rhel9 repository > >**Motivation for the change:** >The helm-operator image is using rhel9 base image from 4.16 onwards and discontinued publishing rhel8 based image. The repository also has changed from `registry.redhat.io/openshift4/ose-helm-operator` to `registry.redhat.io/openshift4/ose-helm-rhel9-operator`. This PR fixes the scaffolded Dockerfile for helm-operator to use the correct image. > >**Checklist** > >If the pull request includes user-facing changes, extra documentation is required: >- [ ] Add a new changelog fragment in `changelog/fragments` (see [`changelog/fragments/00-template.yaml`](https://github.com/operator-framework/operator-sdk/tree/master/changelog/fragments/00-template.yaml)) >- [ ] Add or update relevant sections of the docs website in [`website/content/en/docs`](https://github.com/operator-framework/operator-sdk/tree/master/website/content/en/docs) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Focp-release-operator-sdk). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
TrilokGeer commented 1 month ago

/lgtm

adellape commented 1 month ago

/label docs-approved

Senthamilarasu-STA commented 1 month ago

/label px-approved

openshift-ci-robot commented 1 month ago

@arkadeepsen: Jira Issue OCPBUGS-42425: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42425 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/397): > > >**Description of the change:** >Update base image of scaffolded Dockerfile for helm-operator to use rhel9 repository > >**Motivation for the change:** >The helm-operator image is using rhel9 base image from 4.16 onwards and discontinued publishing rhel8 based image. The repository also has changed from `registry.redhat.io/openshift4/ose-helm-operator` to `registry.redhat.io/openshift4/ose-helm-rhel9-operator`. This PR fixes the scaffolded Dockerfile for helm-operator to use the correct image. > >**Checklist** > >If the pull request includes user-facing changes, extra documentation is required: >- [ ] Add a new changelog fragment in `changelog/fragments` (see [`changelog/fragments/00-template.yaml`](https://github.com/operator-framework/operator-sdk/tree/master/changelog/fragments/00-template.yaml)) >- [ ] Add or update relevant sections of the docs website in [`website/content/en/docs`](https://github.com/operator-framework/operator-sdk/tree/master/website/content/en/docs) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Focp-release-operator-sdk). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
arkadeepsen commented 1 month ago

/cherrypick release-4.17

openshift-cherrypick-robot commented 1 month ago

@arkadeepsen: new pull request created: #399

In response to [this](https://github.com/openshift/ocp-release-operator-sdk/pull/397#issuecomment-2394190294): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-helm-operator This PR has been included in build openshift-enterprise-helm-operator-container-v4.18.0-202410041911.p0.g6e2969e.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-operator-sdk This PR has been included in build openshift-enterprise-operator-sdk-container-v4.18.0-202410041911.p0.g6e2969e.assembly.stream.el9. All builds following this will include this PR.