search

openshift / okd-machine-os

OKD machine OS build scripts and manifests
Apache License 2.0
23 stars 27 forks source link

OCPBUGS-28548: Install ecr-credential-provider from artifacts instead of stub script #743

Closed vrutkovs closed 7 months ago

vrutkovs commented 7 months ago

Depends on https://github.com/openshift/release/pull/48496

openshift-ci-robot commented 7 months ago

@vrutkovs: This pull request references Jira Issue OCPBUGS-28548, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/okd-machine-os/pull/743): >Depends on https://github.com/openshift/release/pull/48496 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fokd-machine-os). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/okd-machine-os/blob/master/OWNERS)~~ [vrutkovs] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vrutkovs commented 7 months ago

/retest

vrutkovs commented 7 months ago

/override ci/prow/e2e-gcp-upgrade

Disruption

/lgtm

openshift-ci[bot] commented 7 months ago

@vrutkovs: you cannot LGTM your own PR.

In response to [this](https://github.com/openshift/okd-machine-os/pull/743#issuecomment-1943370743): >/override ci/prow/e2e-gcp-upgrade > >Disruption > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vrutkovs commented 7 months ago

/cherrypick release-4.15

openshift-cherrypick-robot commented 7 months ago

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/okd-machine-os/pull/743#issuecomment-1943371201): >/cherrypick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 7 months ago

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-gcp-upgrade

In response to [this](https://github.com/openshift/okd-machine-os/pull/743#issuecomment-1943370743): >/override ci/prow/e2e-gcp-upgrade > >Disruption > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 7 months ago

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 7 months ago

@vrutkovs: Jira Issue OCPBUGS-28548: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28548 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/okd-machine-os/pull/743): >Depends on https://github.com/openshift/release/pull/48496 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fokd-machine-os). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 7 months ago

@vrutkovs: new pull request created: #747

In response to [this](https://github.com/openshift/okd-machine-os/pull/743#issuecomment-1943371201): >/cherrypick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.