search

openshift / open-service-broker-sdk

A starting point for creating service brokers implementing the Open Service Broker API
Apache License 2.0
31 stars 33 forks source link

reason to commit vendor directory? #11

Closed jmrodri closed 7 years ago

jmrodri commented 7 years ago

Is there a reason we commit the vendor directory? On our broker, we simply commit the glide.yaml and glide.lock file and added vendor to .gitignore.

bparees commented 7 years ago

makes it less painful to bootstrap a new dev environment, just following the same practices we use in origin (admittedly we use godeps, not glide there).

bparees commented 7 years ago

(in theory it also protects us against someone rewriting history in their repo, or removing their repo entirely)

bparees commented 7 years ago

the service catalog (which uses glide) also follows this pattern, so i'm closing this. https://github.com/kubernetes-incubator/service-catalog/tree/master/vendor