openshift / open-service-broker-sdk

A starting point for creating service brokers implementing the Open Service Broker API
Apache License 2.0
31 stars 33 forks source link

Add example integration test for the broker. #29

Closed maleck13 closed 7 years ago

maleck13 commented 7 years ago

@bparees @jim-minter PTAL when you get chance. Looking for feedback on approach. I will add more integration tests as I have with the unit tests.

bparees commented 7 years ago

approach looks ok to me. please add an invocation of make test to .travis.yml either here or in your other PR (or better still both, so we can validate the tests work before merging :) )

maleck13 commented 7 years ago

@bparees Thanks for review. So for the integration tests, I will look at adding an etcd to the travis file and a make test-integrations call also.

maleck13 commented 7 years ago

Added the etcd and make target call. All tests passing, but one issue is that the only integration test that is there is the catalog endpoint, which doesn't use etcd. I intend to add some more tests as with the unit tests. Is it worth merging as is or wait till there are more integration tests in place?

bparees commented 7 years ago

rename "integrations" to "integration" everywhere and let's merge it is as, best to get a stake in the ground. thanks!

maleck13 commented 7 years ago

Updated as requested

bparees commented 7 years ago

thanks @maleck13!