Closed maleck13 closed 7 years ago
approach looks ok to me. please add an invocation of make test to .travis.yml either here or in your other PR (or better still both, so we can validate the tests work before merging :) )
@bparees Thanks for review. So for the integration tests, I will look at adding an etcd to the travis file and a make test-integrations
call also.
Added the etcd and make target call. All tests passing, but one issue is that the only integration test that is there is the catalog endpoint, which doesn't use etcd. I intend to add some more tests as with the unit tests. Is it worth merging as is or wait till there are more integration tests in place?
rename "integrations" to "integration" everywhere and let's merge it is as, best to get a stake in the ground. thanks!
Updated as requested
thanks @maleck13!
@bparees @jim-minter PTAL when you get chance. Looking for feedback on approach. I will add more integration tests as I have with the unit tests.