search

openshift / openldap

Apache License 2.0
32 stars 59 forks source link

add usefull module #17

Closed gudeyang1 closed 5 years ago

gudeyang1 commented 5 years ago

when imported ldif file contains some objectClass the image don't have will cause error

ldap_add: Invalid syntax (21)
    additional info: objectClass: value #0 invalid per syntax

this module is quite useful , it may added by default

openshift-bot commented 5 years ago

Can one of the admins verify this patch?

openshift-ci-robot commented 5 years ago

Hi @gudeyang1. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stevekuznetsov commented 5 years ago

@gudeyang1 unfortunately this repository holds an implementation that is supposed to be used only internally for a set of tests for OpenShift. We don't accept changes here as we don't expect this to be used anywhere else outside of this context. Please feel free to fork this repo to make your changes there.

/close

openshift-ci-robot commented 5 years ago

@stevekuznetsov: Closing this PR.

In response to [this](https://github.com/openshift/openldap/pull/17#issuecomment-435507660): >@gudeyang1 unfortunately this repository holds an implementation that is supposed to be used _only_ internally for a set of tests for OpenShift. We don't accept changes here as we don't expect this to be used anywhere else outside of this context. Please feel free to fork this repo to make your changes there. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.