search

openshift / openldap

Apache License 2.0
32 stars 59 forks source link

Update to fed29 and install openssl tools #19

Closed mrogers950 closed 3 years ago

mrogers950 commented 5 years ago

I've been converting the Origin LDAP tests to e2e and when using the image for an openldap client I ran into an issue with the client version packaged in centos7. Updating to a fedora 29 base helped.

mrogers950 commented 5 years ago

Not sure what is causing this failure in test because of just the image change: 5d235d09 conn=1001 op=1 MOD dn="olcDatabase={0}config,cn=config" 5d235d09 conn=1001 op=1 MOD attr=olcRootPW 5d235d09 conn=1001 op=1 RESULT tag=103 err=0 text= 5d235d09 conn=1001 op=2 MOD dn="olcDatabase={2}hdb,cn=config" 5d235d09 conn=1001 op=2 MOD attr=olcRootPW olcRootDN olcSuffix 5d235d09 conn=1001 op=2 RESULT tag=103 err=32 text= ldap_modify: No such object (32) matched DN: cn=config

For the e2e tests I'm using a totally different set of cn=config ldif files than the ones being provided in this image in order to get it working. It might be something simple to change about the schema.

stevekuznetsov commented 5 years ago

For the e2e tests I'm using a totally different set of cn=config ldif files than the ones being provided in this image

What do you mean? The image baked in the schema to allow the LDIF to be registered at test run time -- are you saying you're using a separate schema?

mrogers950 commented 5 years ago

For the e2e tests I'm using a totally different set of cn=config ldif files than the ones being provided in this image

What do you mean? The image baked in the schema to allow the LDIF to be registered at test run time -- are you saying you're using a separate schema?

The baked-in ones were failing on modifying cn=config and adding the base objects for some reason, so to get things working I just used different LDIF files for the base and cn=config parts. The actual test schema and objects are the same.

base ldif: https://github.com/openshift/origin/pull/23132/files#diff-12f68d3ef2ef05be002e728fc53ef8fdR24 config ldif: https://github.com/openshift/origin/pull/23132/files#diff-12f68d3ef2ef05be002e728fc53ef8fdR46

mrogers950 commented 5 years ago

@stevekuznetsov I took a different approach to this PR after getting a little more familiar with the project structure. I made a 2.4.46 version based off of fedora 29, using the 2.4.41 contrib files with some modifications needed for make test (although the contrib files here are not important for the Origin use since I'm providing a custom db during the test). Assuming this is OK, how can I get a openshift/openldap-2446-fed29-candidate image published?

stevekuznetsov commented 5 years ago

I think when we built this back in the day, we just pushed manually. Or maybe we did it with the old Jenkins setup. Perhaps today you could add this repo to the larger CI configuration and build out images that way?

mkumatag commented 4 years ago

@mrogers950 Is docker.io/mrogers950/origin-openldap-test:fedora29 image is based on this code which is used in the origin e2e tests?

mrogers950 commented 4 years ago

@mkumatag That's right, it was built on this PR.

mkumatag commented 4 years ago

@stevekuznetsov can we merge this PR meanwhile,? There are some known issues like the naming of the image when multiple versions mentioned - probably I will submit a PR later for that?

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/openshift/openldap/pull/19#issuecomment-731547979): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.