search

openshift / openldap

Apache License 2.0
32 stars 59 forks source link

bug 1999652: Rework repository and version bump image OS to make it work better long term and fix occasional segfault on tests #25

Closed ibihim closed 3 years ago

ibihim commented 3 years ago

What

This is an early PR to verify that I am not digging into the wrong direction.

The main point is to add a newer OS (as of now Fedora:34, but could switch to UBI images) and a newer openLDAP version.

Why

There is a sporadic segfault on openLDAP, we hope that patching the OS / openLDAP will fix it: https://bugzilla.redhat.com/show_bug.cgi?id=1999652.

The current image in use is hosted on a private user account as the PR didn't get merged: https://github.com/openshift/openldap/pull/19.

How

I updated Fedora:29 to Fedora:34. I changed the Makefile, Dockerfile and removed the build.sh. As far as I could tell the squeezing didn't do much.

Next steps

What I would like to add:

What I could add:

ibihim commented 3 years ago

do we need the versioned directories?

I assumed not and so I threw them out. :smile:

openshift-ci[bot] commented 3 years ago

@ibihim: This pull request references Bugzilla bug 1999652, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/openldap/pull/25): >bug 1999652: Rework repository and version bump image OS to make it work better long term and fix occasional segfault on tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ibihim commented 3 years ago

/bugzilla refresh

openshift-ci[bot] commented 3 years ago

@ibihim: This pull request references Bugzilla bug 1999652, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.0) matches configured target release for branch (4.10.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liyao@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/openldap/pull/25#issuecomment-920038495): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stlaz commented 3 years ago

LGTM

s-urbaniak commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

@s-urbaniak: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/openldap/pull/25#issuecomment-922853592): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stlaz commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

@stlaz: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/openldap/pull/25#issuecomment-923819294): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ibihim commented 3 years ago

@s-urbaniak @stlaz , what now?

stlaz commented 3 years ago

/retest the o/release PR merged, let's see

s-urbaniak commented 3 years ago

/override integration

openshift-ci[bot] commented 3 years ago

@s-urbaniak: s-urbaniak unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to [this](https://github.com/openshift/openldap/pull/25#issuecomment-933553045): >/override integration Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
deads2k commented 3 years ago

/override ci/prow/integration

from https://github.com/openshift/openldap/pull/25#issuecomment-933553045

openshift-ci[bot] commented 3 years ago

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/integration

In response to [this](https://github.com/openshift/openldap/pull/25#issuecomment-933557792): >/override ci/prow/integration > >from https://github.com/openshift/openldap/pull/25#issuecomment-933553045 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
s-urbaniak commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

@s-urbaniak: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/openldap/pull/25#issuecomment-933565154): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
s-urbaniak commented 3 years ago

/approve

s-urbaniak commented 3 years ago

/lgtm

s-urbaniak commented 3 years ago

/approve

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibihim, s-urbaniak, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openldap/blob/master/OWNERS)~~ [ibihim,s-urbaniak,stlaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 years ago

@ibihim: All pull requests linked via external trackers have merged:

Bugzilla bug 1999652 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/openldap/pull/25): >bug 1999652: Rework repository and version bump image OS to make it work better long term and fix occasional segfault on tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.