search

openshift / openshift-ansible-contrib

Additional roles and playbooks for OpenShift installation and management
https://www.openshift.com
Apache License 2.0
283 stars 371 forks source link

AWS Ref arch question around ditching cfn #1044

Closed DanyC97 closed 6 years ago

DanyC97 commented 6 years ago

@cooktheryan @mazzystr with the AWS OCP 3.9 red arch i see from this commit that cfn was dropped in favour of ansible modules.

Could you please share the rational behind this action ? I'm only asking because i'm curious, not because i disagree with ;)

Also should i understand that this code is going to be deprecated in favor of the new 3.9 code added recently ?

cooktheryan commented 6 years ago

@DanyC97 I believe its just the start to migrating where we are going in the future in regards to the deployment of AWS resources. Both mechanisms are good cfn and ansible. Ansible deployment has matured from previous iterations where there was potential for items to not deploy or not deploy correctly.

You are correct in the deprecation.

DanyC97 commented 6 years ago

@cooktheryan thanks a bunch for quick response. So am i right to say that the new 3.9 aws code which doesn't rely cfn will also make it/ become the main code vs the aws code currently in openshift-ansible git repo ?

cooktheryan commented 6 years ago

I believe this code in the repository is a stop gap until the aws code in openshift ansible is ready for GA

On Tue, Jun 5, 2018 at 1:17 PM, Dani Comnea notifications@github.com wrote:

@cooktheryan https://github.com/cooktheryan thanks a bunch for quick response. So am i right to say that the new 3.9 aws code which doesn't rely cfn will also make it/ become the main code vs the aws code currently in openshift-ansible git repo ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openshift/openshift-ansible-contrib/issues/1044#issuecomment-394790653, or mute the thread https://github.com/notifications/unsubscribe-auth/ADoslDR71A25ihKE_h0n-fX_9VSEDug3ks5t5r1FgaJpZM4Uag7w .

DanyC97 commented 6 years ago

i see.

@michaelgugino @sdodson @cooktheryan any chance you can share what is it missing from the openshift-ansbile aws code to make it GA ?

I'm asking because i'd like to understand where should i focus helping out: ( i have some internal bespoke solution and would love ditch it in favour of the upstream solution assuming i'm going to ride the ride horse)

is it going to be the work @cooktheryan done (even if that is a stop gap and is completely different - ie no ASG today, no AMI build - but is dead simple to get your head around) or not

DanyC97 commented 6 years ago

most of the questions were asked, closing, thank you!