search

openshift / openshift-ansible-contrib

Additional roles and playbooks for OpenShift installation and management
https://www.openshift.com
Apache License 2.0
283 stars 372 forks source link

wip(satellite): introduce variable enabling satellite-tools repository #1084

Closed faust64 closed 3 years ago

faust64 commented 5 years ago

What does this PR do?

Updates @Vskilet contribution ( #1081 ), introducing a variable switching satellite-tools version, celebrating Satellite 6.4 release.

How should this be manually tested?

Having defined satellite-related configurations, such as rhsm_activation_key, rhsm_org_id, ... Apply prerequisites and deploy cluster:

ansible-playbook playbooks/prerequisite.yaml
ansible-playbook playbooks/deploy-host.yaml

Is there a relevant Issue open for this?

None

Who would you like to review this?

cc: @tomassedovic PTAL

openshift-ci-robot commented 5 years ago

Hi @faust64. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
faust64 commented 5 years ago

All the credit goes to Victor. Couldn't figure out how to push my changes into his PR.

While I'm there, I might be interested into joining the org. The link given above only lists current members, I'ld rather not harass anyone, ... If someone here's willing to further discuss that matter, please let me know, ...

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/openshift/openshift-ansible-contrib/pull/1084#issuecomment-738087268): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.