openshift / openshift-ansible-contrib

Additional roles and playbooks for OpenShift installation and management
https://www.openshift.com
Apache License 2.0
283 stars 372 forks source link

Export Cronjob interprete asterisks by mistake #1091

Closed mieseprem closed 3 years ago

mieseprem commented 5 years ago

BUG REPORT INFO

Environment

Copy of inventory files and custom variables used (please omit your secrets!):
n/a

Command used to invoke ansible:
n/a

Output of ansible run:
n/a

Anything else do we need to know:
This is abou the script reference-architecture/day2ops/scripts/project_export.sh. Part of the project are cronjob configurations and they include crontab style scheduling configuration (e.g. "1 4 /5 *"). Unfortunately the asterisks will be interpreted by shell interpreter. This led to unusable cronjob files. Each asterisk is replaced by names of all files in current working directory.

The incorrect line in code is: if [ "$(echo ${BUFFER} | jq '.items | length > 0')" == "false" ]; then

The BUFFER variable needs to be surrounded by '"'.

mieseprem commented 5 years ago

Hello, this issue is still present. Does no one use the export_project.sh script to export cronjob configurations?

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/openshift-ansible-contrib/issues/1091#issuecomment-727297381): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.