search

openshift / openshift-ansible-contrib

Additional roles and playbooks for OpenShift installation and management
https://www.openshift.com
Apache License 2.0
283 stars 372 forks source link

Check jq as required command in project_import.sh #1103

Closed eramoto closed 3 years ago

eramoto commented 4 years ago

What does this PR do?

Check jq as required command even if project_export.sh is run on a machine and project_import.sh is run on another machine.

How should this be manually tested?

If jq command exists, the shell script outputs Are you sure? (You enter n when you want to cancel it)

$ which oc
/usr/bin/oc
$ which jq
/usr/bin/jq
$ reference-architecture/day2ops/scripts/project_import.sh foobar
...
Are you sure? n
User cancel

If jq command does not exist, the shell script outputs jq required but not found

$ which oc
/usr/bin/oc
$ which jq 
/usr/bin/which: no jq in (/usr/share/Modules/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin)
$ reference-architecture/day2ops/scripts/project_import.sh foobar
jq required but not found

Is there a relevant Issue open for this?

None.

Who would you like to review this?

cc: @tomassedovic PTAL

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/openshift/openshift-ansible-contrib/pull/1103#issuecomment-735456121): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.