search

openshift / openshift-ansible

Install and config an OpenShift 3.x cluster
https://try.openshift.com
Apache License 2.0
2.18k stars 2.31k forks source link

CRI-O: Make selinux option configurable #10283

Closed jkroepke closed 1 year ago

jkroepke commented 6 years ago

Description

Currently the selinux option in crio is hardcoded

https://github.com/openshift/openshift-ansible/blob/ff568eadd5b6d993b89f0ccde1cca9ff3140f86b/roles/container_runtime/templates/crio.conf.j2#L89

It should be configurable like in the docker configuration

https://github.com/openshift/openshift-ansible/blob/6d7f8662d3fe8be6731986e85f3659fb34c8819e/roles/container_runtime/templates/daemon.json#L17

OR

https://github.com/openshift/openshift-ansible/blob/e25f1a50d23ff8548ccf73313c0495a0f4260ce1/roles/container_runtime/tasks/package_docker.yml#L113

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

jkroepke commented 4 years ago

/remove-lifecycle rotten

jkroepke commented 4 years ago

/lifecycle frozen

barbacbd commented 1 year ago

/close

openshift-ci[bot] commented 1 year ago

@barbacbd: Closing this issue.

In response to [this](https://github.com/openshift/openshift-ansible/issues/10283#issuecomment-1553055649): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.