openshift / openshift-ansible

Install and config an OpenShift 3.x cluster
https://try.openshift.com
Apache License 2.0
2.18k stars 2.31k forks source link

OCPBUGS-29150: Align IPSEC with RHCOS #12483

Closed patrickdillon closed 7 months ago

patrickdillon commented 7 months ago

ipsec: edit /etc/ipsec.conf to modify nssdir

Add and enable ipsec service

12482 for some reason could not get a clean cherry-pick. So this is a manual cherry-pick which also includes #12481

openshift-ci-robot commented 7 months ago

@patrickdillon: This pull request references Jira Issue OCPBUGS-29150, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-28676](https://issues.redhat.com//browse/OCPBUGS-28676) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-28676](https://issues.redhat.com//browse/OCPBUGS-28676) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0 * bug has dependents

Requesting review from QA contact: /cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/openshift-ansible/pull/12483): >[ipsec: edit /etc/ipsec.conf to modify nssdir](https://github.com/openshift/openshift-ansible/commit/7045d83cafd2ac8a7b3804770f902c29c87c317b) > >[Add and enable ipsec service](https://github.com/openshift/openshift-ansible/commit/4a057a46cea61e29fc91b6dc1978c80e8d96b18b) > >#12482 for some reason could not get a clean cherry-pick. So this is a manual cherry-pick which also includes #12481 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-ansible). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
patrickdillon commented 7 months ago

/hold screwed up the rebase

patrickdillon commented 7 months ago

/retest

patrickdillon commented 7 months ago

/hold cancel

openshift-ci[bot] commented 7 months ago

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel8 152a4424d234f4eb93b9d04eb32bd7c9bfe2ee4e link true /test e2e-aws-workers-rhel8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-ansible/blob/release-4.15/OWNERS)~~ [barbacbd,patrickdillon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 7 months ago

@patrickdillon: Jira Issue OCPBUGS-29150: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-29150 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/openshift-ansible/pull/12483): >[ipsec: edit /etc/ipsec.conf to modify nssdir](https://github.com/openshift/openshift-ansible/commit/7045d83cafd2ac8a7b3804770f902c29c87c317b) > >[Add and enable ipsec service](https://github.com/openshift/openshift-ansible/commit/4a057a46cea61e29fc91b6dc1978c80e8d96b18b) > >#12482 for some reason could not get a clean cherry-pick. So this is a manual cherry-pick which also includes #12481 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-ansible). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.