Health check ignores openshift_disable_check=docker_storage option

[deuther]

Description

Title says it all, I believe.

Version

ansible 2.4.1.0
  config file = None
  configured module search path = [u'/home/xxx/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/xxx/workspace/vproject/lib/python2.7/site-packages/ansible
  executable location = /home/xxx/workspace/vproject/bin/ansible
  python version = 2.7.14 (default, Oct 16 2017, 14:53:38) [GCC 6.2.0 20161005]

The output of git describe:

openshift-ansible-3.7.0-0.195.0

Steps To Reproduce

1. Run the byo/config.yml

Expected Results

Health check directive applied, cluster successfully installed.

Observed Results

  1. Hosts:    lab-os3-master0.xxx.lab, lab-os3-node0.xxx.lab, lab-os3-node1.xxx.lab
     Play:     OpenShift Health Checks
     Task:     Run health checks (install) - EL
     Message:  One or more checks failed
     Details:  check "docker_storage":
               Use of loopback devices with the Docker devicemapper storage driver
               (the default storage configuration) is unsupported in production.
               Please use docker-storage-setup to configure a backing storage volume.
               See http://red.ht/2rNperO for further information.

Additional Information

Inventory file:

[OSEv3:children]
masters
nodes
etcd

[OSEv3:vars]
containerized=true
ansible_ssh_user=centos
ansible_become=yes
enable_excluders=false
enable_docker_excluder=false
openshift_disable_check=docker_storage
deployment_type=origin
openshift_deployment_type=origin
openshift_disable_check=docker_image_availability
openshift_use_system_containers=False
osm_default_node_selector='region=primary'
openshift_hosted_router_selector='region=infra'
openshift_hosted_registry_selector='region=infra'
openshift_master_default_subdomain=xxx.lab
openshift_release=v3.7
openshift_image_tag=v3.7.0-rc.0
openshift_install_examples=False

[deuther]

Hmm, looks like the problem is related to the multiple openshift_disable_check lines. Should be something like this: openshift_disable_check=docker_image_availability,disk_availability,memory_availability,docker_storage

[michaelgugino]

@deuther That variable supports a yaml list. If specifying in your inventory, it should look like this:

var1=['foo', 'bar']

[deuther]

@michaelgugino yep, I've figured this out, pls see my comment above. Thanks, anyway