openshift / openshift-apiserver

Coming soon. Do not import.
39 stars 85 forks source link

OCPBUGS-35036: fail image import when both image and error are nil #448

Closed flavianmissi closed 1 month ago

flavianmissi commented 1 month ago

I still can't wrap my head around what situation(s) could cause this state where both the image and the error are nil.

To try and unblock CI folks, I solved the panic without addressing the root cause, since I haven't been able to trace it. To help us understand this state in the future, the code now also logs some extra information when it hits the state that previously caused the panic to happen.

openshift-ci-robot commented 1 month ago

@flavianmissi: This pull request references Jira Issue OCPBUGS-35036, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/openshift-apiserver/pull/448): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-apiserver). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
flavianmissi commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@flavianmissi: This pull request references Jira Issue OCPBUGS-35036, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wewang58

In response to [this](https://github.com/openshift/openshift-apiserver/pull/448#issuecomment-2361094306): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-apiserver). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@flavianmissi: This pull request references Jira Issue OCPBUGS-35036, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wewang58

In response to [this](https://github.com/openshift/openshift-apiserver/pull/448): >I still can't wrap my head around what situation(s) could cause this state where both the image and the error are nil (see [linked PR](https://github.com/openshift/openshift-apiserver/pull/448) for details). > >To try and unblock CI folks, I solved the panic without addressing the root cause, since I haven't been able to trace it. To help us understand this state in the future, the code now also logs some extra information when it hits the state that previously caused the panic to happen. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-apiserver). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tkashem commented 1 month ago

/lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/image/OWNERS](https://github.com/openshift/openshift-apiserver/blob/master/pkg/image/OWNERS)~~ [flavianmissi,tkashem] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
flavianmissi commented 1 month ago

/cherry-pick release-4.17 release-4.16

openshift-cherrypick-robot commented 1 month ago

@flavianmissi: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/openshift-apiserver/pull/448#issuecomment-2361270615): >/cherry-pick release-4.17 release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD ed19c8192b6c3d7e9271d8a12c6ce2efca13a444 and 2 for PR HEAD a29a7de35b634a26cb01ea5eacccf41ccfc01488 in total

openshift-ci[bot] commented 1 month ago

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@flavianmissi: Jira Issue OCPBUGS-35036: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35036 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/openshift-apiserver/pull/448): >I still can't wrap my head around what situation(s) could cause this state where both the image and the error are nil. > >To try and unblock CI folks, I solved the panic without addressing the root cause, since I haven't been able to trace it. To help us understand this state in the future, the code now also logs some extra information when it hits the state that previously caused the panic to happen. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fopenshift-apiserver). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 1 month ago

@flavianmissi: new pull request created: #450

In response to [this](https://github.com/openshift/openshift-apiserver/pull/448#issuecomment-2361270615): >/cherry-pick release-4.17 release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-openshift-apiserver This PR has been included in build ose-openshift-apiserver-container-v4.18.0-202409200008.p0.gcbd2b66.assembly.stream.el9. All builds following this will include this PR.