[release-v16] changenotes and pluginconfig for 16.1

[ehashman]

NONE

[ehashman]

Just to be safe, I'm currently testing this by spinning up a v15.0 cluster with Azure monitoring enabled. I will then upgrade to 16.1.

[ehashman]

/hold

Hmm, this does not actually appear to be working:

time="2020-04-10T01:32:43Z" level=info msg="starting sync"
time="2020-04-10T01:32:45Z" level=debug msg="applying crd resources"
time="2020-04-10T01:32:45Z" level=debug msg="applying ns resources"
time="2020-04-10T01:32:46Z" level=debug msg="applying sa resources"
time="2020-04-10T01:32:48Z" level=debug msg="applying cfg resources"
time="2020-04-10T01:32:49Z" level=debug msg="applying storageClass resources"
time="2020-04-10T01:32:49Z" level=debug msg="applying service resources"
time="2020-04-10T01:32:49Z" level=debug msg="applying role and clusterRole resources"
time="2020-04-10T01:32:54Z" level=debug msg="applying roleBinding and clusterRoleBinding resources"
time="2020-04-10T01:32:58Z" level=debug msg="waiting for admission controller pods"
time="2020-04-10T01:32:58Z" level=debug msg="applying validatingwebhookconfiguration resources"
time="2020-04-10T01:32:59Z" level=debug msg="applying other resources"
time="2020-04-10T01:32:59Z" level=info msg="Update DaemonSet.apps/openshift-azure-logging/omsagent"
time="2020-04-10T01:32:59Z" level=info msg="...[snip]"
time="2020-04-10T01:33:00Z" level=info msg="sync error: DaemonSet.apps \"omsagent\" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{\"component\":\"oms-agent\", \"tier\":\"node\"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable"

[ehashman]

Oh, I wonder if it upgraded to the right version of sync pod. Let me check.

Edit: nope, probably because I failed to update the latest version of the plugin:

     Image:         osarpint.azurecr.io/openshift-on-azure/azure:v16.0

Well, at least I've confirmed the upgrade failure bug :sweat_smile:

[ehashman]

Okay, successfully upgraded with no delay after correctly applying patches. I've pushed an updated v16.1 image.

/hold cancel

[ehashman]

/retest

[jim-minter]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, jim-minter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-azure/blob/release-v16/OWNERS)~~ [ehashman,jim-minter] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[ehashman]

/cherry-pick master

[openshift-cherrypick-robot]

@ehashman: #2273 failed to apply on top of branch "master":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A   CHANGELOG.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): CHANGELOG.md deleted in HEAD and modified in Add release notes for 16.1. Version Add release notes for 16.1 of CHANGELOG.md left in tree.
Patch failed at 0001 Add release notes for 16.1

In response to [this](https://github.com/openshift/openshift-azure/pull/2273#issuecomment-613697637): >/cherry-pick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[ehashman]

rude