openshift / openshift-azure

Azure Red Hat Openshift

https://azure.microsoft.com/en-us/services/openshift/

Apache License 2.0

49 stars 51 forks source link

Remove outdated SCAP benchmarks, disable false negatives #2274

Closed ehashman closed 4 years ago

ehashman commented 4 years ago

NONE

Addresses (but does not fix) #2269.

ehashman commented 4 years ago

/test vmimage

codecov[bot] commented 4 years ago

Codecov Report

Merging #2274 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2274   +/-   ##
=======================================
  Coverage   40.19%   40.19%           
=======================================
  Files         291      291           
  Lines       21603    21603           
=======================================
  Hits         8684     8684           
  Misses      12405    12405           
  Partials      514      514

ehashman commented 4 years ago

/test vmimage

ehashman commented 4 years ago

/test vmimage

ehashman commented 4 years ago

flake

/retest

ehashman commented 4 years ago

Changes here:

Remove the SCAP benchmarks that were coming up as warnings in the logs, e.g. https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/periodic-ci-azure-vmimage-validate-osa311-latest/200#1:build-log.txt%3A257
Disabled the two SCAP benchmarks that are false failures while we wait for an upstream fix, see https://bugzilla.redhat.com/show_bug.cgi?id=1823576#c3 for details

nilsanderselde commented 4 years ago

/lgtm

kwoodson commented 4 years ago

@ehashman

What's the plan to manage these longer term? Once these get fixed upstream, are we planning on adding these back?

Other than that it looks good to me.

ehashman commented 4 years ago

What's the plan to manage these longer term? Once these get fixed upstream, are we planning on adding these back?

Yes, that's my plan. I'm subscribed to the upstream bugzilla so should know when the fixes become available.

kwoodson commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, kwoodson, nilsanderselde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/openshift-azure/blob/master/OWNERS)~~ [ehashman,kwoodson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment